From 0c751ce72e828a0ab3783e2e5a6cad0da2d18ffd Mon Sep 17 00:00:00 2001 From: Aram Sargsyan Date: Fri, 5 May 2023 10:46:37 +0000 Subject: [PATCH] Update the event loop's time after executing a task Tasks can block for a long time, especially when used by tools in interactive mode. Update the event loop's time to avoid unexpected errors when processing later events during the same callback. For example, newly started timers can fire too early, because the current time was stale. See the note about uv_update_time() in the https://docs.libuv.org/en/v1.x/timer.html#c.uv_timer_start page. --- lib/isc/netmgr/netmgr.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lib/isc/netmgr/netmgr.c b/lib/isc/netmgr/netmgr.c index 00a7945edb..b19d468820 100644 --- a/lib/isc/netmgr/netmgr.c +++ b/lib/isc/netmgr/netmgr.c @@ -847,6 +847,16 @@ isc__nm_async_task(isc__networker_t *worker, isc__netievent_t *ev0) { result = isc_task_run(ievent->task); + /* + * Tasks can block for a long time, especially when used by tools in + * interactive mode. Update the event loop's time to avoid unexpected + * errors when processing later events during the same callback. + * For example, newly started timers can fire too early, because the + * current time was stale. See the note about uv_update_time() in the + * https://docs.libuv.org/en/v1.x/timer.html#c.uv_timer_start page. + */ + uv_update_time(&worker->loop); + switch (result) { case ISC_R_QUOTA: isc_task_ready(ievent->task);