upstream/bind9
1
0
Fork 0
mirror of https://github.com/isc-projects/bind9.git synced 2026-05-28 04:34:54 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

rem: dev: remove dns_zone_dump

Browse source 
Zone API `dns_zone_dump` is dead code in 9.21 (and was also dead code at
least in 9.20), removing it.

Merge branch 'colin/remove-dns_zone_dump' into 'main'

See merge request isc-projects/bind9!11060
This commit is contained in:
Colin Vidal 2025-10-08 09:37:50 +02:00
commit 0750603569
2 changed files with 7 additions and 36 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
lib/dns/include/dns/zone.h
View file

@ -613,34 +613,21 @@ dns_zone_flush(dns_zone_t *zone);
*\li 'zone' to be a valid zone.
*/
isc_result_t
dns_zone_dump(dns_zone_t *zone);
/*%<
* Write the zone to database.
*
* Require:
*\li 'zone' to be a valid zone.
*/
isc_result_t
dns_zone_dumptostream(dns_zone_t *zone, FILE *fd, dns_masterformat_t format,
const dns_master_style_t *style,
const uint32_t rawversion);
/*%<
* Write the zone to stream 'fd' in the specified 'format'.
* If the 'format' is dns_masterformat_text (RFC1035), 'style' also
* specifies the file style (e.g., &dns_master_style_default).
*
* dns_zone_dumptostream() is a backward-compatible form of
* dns_zone_dumptostream2(), which always uses the dns_masterformat_text
* format and the dns_master_style_default style.
* If 'format' is dns_masterformat_text (RFC1035), 'style'
* specifies the file style (e.g., &dns_master_style_default),
* and 'rawversion' is ignored.
*
* dns_zone_dumptostream2() is a backward-compatible form of
* dns_zone_dumptostream3(), which always uses the current
* default raw file format version.
*
* Note that dns_zone_dumptostream3() is the most flexible form. It
* can also provide the functionality of dns_zone_fulldumptostream().
* If 'format' is dns_masterformat_raw, 'style' is ignored, and
* 'rawversion" specifies the format verson of the raw zone file:
* version 0 raw files can be read by all BIND 9 releases;
* version 1 was introduced in BIND 9.9.
*
* Require:
*\li 'zone' to be a valid zone.

16
lib/dns/zone.c
View file

@ -12165,22 +12165,6 @@ dns_zone_flush(dns_zone_t *zone) {
return result;
}
isc_result_t
dns_zone_dump(dns_zone_t *zone) {
isc_result_t result = ISC_R_ALREADYRUNNING;
bool dumping;
REQUIRE(DNS_ZONE_VALID(zone));
LOCK_ZONE(zone);
dumping = was_dumping(zone);
UNLOCK_ZONE(zone);
if (!dumping) {
result = zone_dump(zone, false);
}
return result;
}
static void
zone_needdump(dns_zone_t *zone, unsigned int delay) {
isc_time_t dumptime;