From af809329b3e31aa42851feea4dc0931bd219bd16 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0t=C4=9Bp=C3=A1n=20Bal=C3=A1=C5=BEik?= Date: Tue, 6 Jan 2026 15:12:25 +0100 Subject: [PATCH 1/3] Use git_clone_bind9-qa anchor in .system_test_common This was missed in abecddb13afa3f8ad9611f1241a635fbe6b90818. --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 243a98c88f..1fc3d4825f 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -543,7 +543,7 @@ stages: - if pytest --version | grep -F "pytest 9.0" >/dev/null; then echo "filterwarnings = ignore::pytest.PytestRemovedIn9Warning" >> pytest.ini; fi - > ("$PYTEST" --junit-xml="$CI_PROJECT_DIR"/junit.xml -n "$TEST_PARALLEL_JOBS" | tee pytest.out.txt) || RET=1 - - git clone --depth 1 https://gitlab.isc.org/isc-projects/bind9-qa.git + - *git_clone_bind9-qa - > "$PYTHON" bind9-qa/ci/postprocess_junit_files.py "$CI_PROJECT_DIR"/junit.xml --output "$CI_PROJECT_DIR"/junit.xml - (exit $RET) From 1a85a27f54e270060c7dead8e227ad8cec43283a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0t=C4=9Bp=C3=A1n=20Bal=C3=A1=C5=BEik?= Date: Tue, 6 Jan 2026 12:03:04 +0100 Subject: [PATCH 2/3] Don't overwrite JUnit file generated by pytest in post-processing When both input and output files are the same, it creates unnecesary troubles in debugging issues with the JUnit files. Keep the Pytest-generated file in the artifacts and output the checked version as a new file. --- .gitlab-ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 1fc3d4825f..d866b72294 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -542,10 +542,10 @@ stages: # This should be fixed before pytest 9.1, when it becomes ineffective. - if pytest --version | grep -F "pytest 9.0" >/dev/null; then echo "filterwarnings = ignore::pytest.PytestRemovedIn9Warning" >> pytest.ini; fi - > - ("$PYTEST" --junit-xml="$CI_PROJECT_DIR"/junit.xml -n "$TEST_PARALLEL_JOBS" | tee pytest.out.txt) || RET=1 + ("$PYTEST" --junit-xml="$CI_PROJECT_DIR"/junit_pytest.xml -n "$TEST_PARALLEL_JOBS" | tee pytest.out.txt) || RET=1 - *git_clone_bind9-qa - > - "$PYTHON" bind9-qa/ci/postprocess_junit_files.py "$CI_PROJECT_DIR"/junit.xml --output "$CI_PROJECT_DIR"/junit.xml + "$PYTHON" bind9-qa/ci/postprocess_junit_files.py "$CI_PROJECT_DIR"/junit_pytest.xml --output "$CI_PROJECT_DIR"/junit.xml - (exit $RET) - '( ! grep -F "grep: warning:" pytest.out.txt )' - test "$CLEAN_BUILD_ARTIFACTS_ON_SUCCESS" -eq 0 || ( cd ../../.. && ninja -C build clean >/dev/null 2>&1 ) @@ -949,10 +949,10 @@ cross-version-config-tests: # file impossible (GitLab Runner uses "set -o pipefail"). - RET=0 - > - "$PYTEST" --setup-only --junit-xml="$CI_PROJECT_DIR"/junit.xml -n "${TEST_PARALLEL_JOBS:-1}" || RET=1 + "$PYTEST" --setup-only --junit-xml="$CI_PROJECT_DIR"/junit_pytest.xml -n "${TEST_PARALLEL_JOBS:-1}" || RET=1 - *git_clone_bind9-qa - > - "$PYTHON" bind9-qa/ci/postprocess_junit_files.py "$CI_PROJECT_DIR"/junit.xml --output "$CI_PROJECT_DIR"/junit.xml + "$PYTHON" bind9-qa/ci/postprocess_junit_files.py "$CI_PROJECT_DIR"/junit_pytest.xml --output "$CI_PROJECT_DIR"/junit.xml - (exit $RET) needs: - job: ci-variables From 0f2d0daabc47eaa5fbde2ceb0b30c35df9f9e255 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C5=A0t=C4=9Bp=C3=A1n=20Bal=C3=A1=C5=BEik?= Date: Tue, 6 Jan 2026 16:42:34 +0100 Subject: [PATCH 3/3] Generate, check the JUnit reports for the doctest job Pass it to GitLab for display. --- .gitlab-ci.yml | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d866b72294..5a6ac3dc69 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -771,13 +771,29 @@ meson-format: doctest: <<: *precheck_job needs: [] + # This script needs to: 1) fail if the doctest fails, 2) fail if + # the junit.xml file is broken, 3) produce the junit.xml file even if + # the doctest fails. Therefore, $RET is used to "cache" the + # result of running pytest as interrupting the script immediately when + # a doctest fails would make checking the contents of the junit.xml + # file impossible (GitLab Runner uses "set -o pipefail"). script: - *configure - meson compile -C build system-test-init + - *find_python - *find_pytest - cd bin/tests/system/isctest + - RET=0 - > - "$PYTEST" --noconftest --doctest-modules + "$PYTEST" --noconftest --doctest-modules --junit-xml="$CI_PROJECT_DIR/junit_doctest.xml" || RET=1 + - *git_clone_bind9-qa + - > + "$PYTHON" bind9-qa/ci/postprocess_junit_files.py "$CI_PROJECT_DIR/junit_doctest.xml" --output "$CI_PROJECT_DIR/junit.xml" + - (exit $RET) + artifacts: + reports: + junit: + - junit.xml pylint: <<: *precheck_job