Merge branch '3125-log-hard-quota-when-not-accepting-the-connection' into 'main'

Add log message when hard quota is reached in TCP accept

Closes #3125

See merge request isc-projects/bind9!5788

CHANGES

@@ -1,3 +1,6 @@
+5801.	[bug]		Log "quota reached" message when hard quota
+			is reached when accepting a connection. [GL #3125]
+
 5800.	[func]		Add ECS support to the DLZ interface. [GL #3082]
 
 5799.	[bug]		Use L1 cache-line size detected at runtime. [GL #3108]

doc/notes/notes-current.rst

@@ -49,3 +49,6 @@ Bug Fixes
 - A failed view configuration during a named reconfiguration procedure could
   cause inconsistencies in BIND internal structures, causing a crash or other
   unexpected errors.  This has been fixed.  :gl:`#3060`
+
+- Restore logging "quota reached" message when accepting connection is over
+  hard quota.  :gl:`#3125`

lib/isc/netmgr/tcp.c

@@ -628,7 +628,7 @@ tcp_connection_cb(uv_stream_t *server, int status) {
 					     &ssock->quotacb);
 		if (result == ISC_R_QUOTA) {
 			isc__nm_incstats(ssock, STATID_ACCEPTFAIL);
-			return;
+			goto done;
 		}
 	}
 

lib/isc/netmgr/tcpdns.c

@@ -597,7 +597,7 @@ tcpdns_connection_cb(uv_stream_t *server, int status) {
 					     &ssock->quotacb);
 		if (result == ISC_R_QUOTA) {
 			isc__nm_incstats(ssock, STATID_ACCEPTFAIL);
-			return;
+			goto done;
 		}
 	}
 

lib/isc/netmgr/tlsdns.c

@@ -670,7 +670,7 @@ tlsdns_connection_cb(uv_stream_t *server, int status) {
 					     &ssock->quotacb);
 		if (result == ISC_R_QUOTA) {
 			isc__nm_incstats(ssock, STATID_ACCEPTFAIL);
-			return;
+			goto done;
 		}
 	}