Mathieu Benoit
7c83dd1fc8
La lecture passait par « sudo sh -c cat » sans jamais demander si le privilège était nécessaire. Elle est appelée une fois par VM pour afficher une liste, et toutes les trois secondes pendant dix minutes par l'attente d'une VM : l'invite root tombait donc en boucle au milieu d'un écran, ce qui entraîne à taper un mot de passe root dans ce qui le demande. La lecture directe passe d'abord et suffit sur une installation standard, ces fichiers d'état étant en 0644 là où le « .conf » voisin est en 0600. Le privilège n'est tenté qu'ensuite, avec « -n », qui échoue au lieu de demander ; un répertoire interdit rend un glob vide, d'où l'essai même sans chemin trouvé. Les deux appelants se replient déjà sur une autre source. Vérifié : 12 tests. --- EN --- The read went through "sudo sh -c cat" without ever asking whether the privilege was needed. It is called once per VM to display a list, and every three seconds for ten minutes while waiting on a VM: the root prompt therefore landed in a loop in the middle of a screen, which trains someone to type a root password into whatever asks for it. The direct read comes first and suffices on a standard install, those status files being 0644 where the neighbouring ".conf" is 0600. The privilege is only tried afterwards, with "-n", which fails instead of asking; a forbidden directory returns an empty glob, hence the attempt even with no path found. Both callers already fall back to another source. Checked: 12 tests. Assisted-by: Claude Opus 5 |
||
|---|---|---|
| .. | ||
| assistant | ||
| assistant_menu.py | ||
| auto_ask.py | ||
| database_manager.py | ||
| deploy_form_extras.py | ||
| deploy_form_lib.py | ||
| deploy_form_plan.py | ||
| dev_tools.py | ||
| kdbx_manager.py | ||
| logo_ascii.txt | ||
| longtest_menu.py | ||
| migration_form.py | ||
| migration_stats.py | ||
| migration_status.py | ||
| migration_status_tui.py | ||
| proxmox_deploy_form.py | ||
| proxmox_menu.py | ||
| qemu_access.py | ||
| qemu_deploy.py | ||
| qemu_deploy_form.py | ||
| qemu_hardware.py | ||
| qemu_install.py | ||
| qemu_install_monitor.py | ||
| qemu_manage.py | ||
| qemu_menu.py | ||
| qemu_network.py | ||
| qemu_privilege.py | ||
| qemu_recover.py | ||
| README.base.md | ||
| README.fr.md | ||
| README.md | ||
| source_todo.sh | ||
| textual_setup.py | ||
| todo.json | ||
| todo.py | ||
| todo_example.json | ||
| todo_file_browser.py | ||
| todo_i18n.py | ||
| todo_install.py | ||
| todo_prefs.py | ||
| todo_telemetry.py | ||
| todo_upgrade.py | ||
| version_manager.py | ||
| vpn_menu.py | ||
TODO is an assistant robot to use ERPLibre
Execute it with ./script/todo/todo.py or make todo.
For a new project, copy todo_example.json to private/todo/todo_override.json | private/todo/todo_override_private.json and edit it.
The mail/ package is the mail client reachable from Assistant > Mail:
several IMAP/SMTP accounts, a local cache, and a Textual TUI. See
../../doc/EMAIL.md.
Where the code lives
todo.py carries the menus and the general helpers. Everything around a
single subject sits in its own file, and the whole thing is assembled by
mixins on the TODO class — one file, one subject, its header states its
boundary.
| File | What it owns |
|---|---|
todo.py |
the menus, the configuration, the general helpers |
qemu_menu.py |
the QEMU/KVM menu, the image catalogue, the statistics |
qemu_deploy.py |
deciding then running a deployment |
qemu_install.py |
the recipes run inside a VM |
qemu_manage.py |
lifecycle, disks, hardware, cleanup, addresses |
qemu_access.py |
SSH, tunnels, consoles, Android emulator |
proxmox_menu.py |
the same, on a REMOTE Proxmox VE host |
The two deployment forms — libvirt here, Proxmox over there — ask the same questions, so they share a foundation rather than each holding a copy:
| File | What it owns |
|---|---|
deploy_form_lib.py |
pure logic (sizes, plan, totals, spec), the shared CSS, the resource-row factory, the progress view |
deploy_form_plan.py |
the plan's gestures: overrides, locks, copies, renaming, free values |
qemu_deploy_form.py |
what QEMU/KVM adds: desktops, tools, branches, install profiles |
proxmox_deploy_form.py |
what Proxmox adds: host, storage, bridge, VMID, address |
A form inherits PlanMixin and provides three hooks: which presets each
resource offers, the name a VM would fall back to, and what a lock freezes.
test_todo_deploy_form_lib.py fails if a form redefines a gesture the
foundation already carries — that is what keeps the architecture from drifting
back into two copies.