Mathieu Benoit
41f0bc4897
Emptying PROCESSEDEXAMPLEFILES_PS was not enough: contrib/hdtbl/examples/mixed_pickles.roff:51: error: cannot open 'gnu.eps' fatal error: PSPIC failed to include 'gnu.eps' hdtbl renders its example tables to PostScript and one of them shows the GNU logo. Rather than chase a third, the consumers were COUNTED: exactly two files include it, doc/webpage.ms and mixed_pickles.roff. Both lists are emptied, and the hook now fails loudly if a third ever appears -- so the next reader gets a sentence instead of a PSPIC error. Considered and rejected: supplying a placeholder gnu.eps. It would have ended the whack-a-mole in one line, and it would have put a blank box where a logo belongs in a document this port then ships. Not rendering the document at all is honest; rendering it wrong is not. --- FR --- Vider PROCESSEDEXAMPLEFILES_PS ne suffisait pas : contrib/hdtbl/examples/mixed_pickles.roff:51: error: cannot open 'gnu.eps' fatal error: PSPIC failed to include 'gnu.eps' hdtbl rend ses tables d'exemple en PostScript, et l'une montre le logo GNU. Plutôt que d'en poursuivre un troisième, les consommateurs ont été COMPTÉS : exactement deux fichiers l'incluent, doc/webpage.ms et mixed_pickles.roff. Les deux listes sont vidées, et le hook échoue bruyamment si un troisième apparaît — le prochain lecteur aura une phrase au lieu d'une erreur PSPIC. Envisagé puis rejeté : fournir un gnu.eps de remplacement. Cela aurait clos la poursuite en une ligne, et aurait mis un cadre vide là où un logo doit être, dans un document que ce portage livre ensuite. Ne pas rendre le document est honnête ; le rendre faux ne l'est pas. Assisted-by: Claude Opus 5
78 lines
4.4 KiB
Bash
Executable file
78 lines
4.4 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
# groff: one decorative figure, and no netpbm to draw it.
|
|
#
|
|
# program 'xpmtoppm' is missing; can't generate doc/gnu.eps
|
|
# make[2]: *** [Makefile:19801: doc/gnu.eps] Error 1
|
|
#
|
|
# xpmtoppm belongs to netpbm. What it produces is the GNU logo, as EPS, for
|
|
# groff's own manual -- and getting it would mean packaging netpbm and the image
|
|
# libraries under it (libjpeg-turbo, libpng, libtiff, jbigkit), none of which
|
|
# anything else in this bootstrap wants.
|
|
#
|
|
# NO CONFIGURE SWITCH EXISTS: groff's configure has neither --without-doc nor
|
|
# --disable-doc, so there was nothing to turn off. Adding an invented flag would
|
|
# have been worse than useless -- autoconf merely warns about options it does not
|
|
# know, the build would have failed identically, and the hook's own check would
|
|
# have passed.
|
|
#
|
|
# The Makefile is generated, so it is edited after configure and before make. The
|
|
# variable is emptied rather than the rule patched, because the INSTALL side is
|
|
# already tolerant:
|
|
#
|
|
# if test -f "$$d/gnu.eps"; then ... fi
|
|
#
|
|
# so with nothing built, nothing is installed and nothing complains. One line,
|
|
# and the only one whose absence the rest of the Makefile already handles.
|
|
set -euo pipefail
|
|
python3 - <<'ZZPY'
|
|
import io, re
|
|
lines = io.open("PKGBUILD", encoding="utf-8").read().split("\n")
|
|
mk = [i for i, l in enumerate(lines) if re.match(r"^[ \t]*make[ \t]*$", l)]
|
|
assert len(mk) >= 1, "groff: no bare `make` line found in build()"
|
|
i = mk[0]
|
|
ind = re.match(r"^[ \t]*", lines[i]).group(0)
|
|
lines[i:i] = [
|
|
ind + "# doc/gnu.eps needs xpmtoppm from netpbm, which this port does not",
|
|
ind + "# package. The install side already skips the file when it is absent.",
|
|
ind + 'sed -i "s|^DOC_GNU_EPS = doc/gnu.eps$|DOC_GNU_EPS =|" Makefile',
|
|
ind + 'grep -q "^DOC_GNU_EPS =$" Makefile',
|
|
ind + "# And its CONSUMER. Emptying DOC_GNU_EPS removed the rule that",
|
|
ind + "# builds the figure and not the document that includes it:",
|
|
ind + "#",
|
|
ind + "# doc/webpage.ms:45: error: cannot open 'gnu.eps'",
|
|
ind + "# doc/webpage.ms:45: fatal error: PSPIC failed to include 'gnu.eps'",
|
|
ind + "#",
|
|
ind + "# PROCESSEDEXAMPLEFILES_PS lists webpage.ps and grnexmpl.ps. The",
|
|
ind + "# HTML variant right above it is ALREADY empty, with its real value",
|
|
ind + "# left as a comment -- groff's own configure empties that one when",
|
|
ind + "# the tools are missing. This does the same for PS, which is the",
|
|
ind + "# decision groff would have made had it checked.",
|
|
ind + 'sed -i "/^PROCESSEDEXAMPLEFILES_PS = /,/^$/ s|^.*$||" Makefile',
|
|
ind + 'grep -q "^PROCESSEDEXAMPLEFILES_PS" Makefile && { echo "groff: PS example list not emptied" >&2; exit 1; }',
|
|
ind + "# THE SECOND consumer. Two files include the logo, and only two --",
|
|
ind + "# counted rather than guessed:",
|
|
ind + "#",
|
|
ind + "# doc/webpage.ms (above)",
|
|
ind + "# contrib/hdtbl/examples/mixed_pickles.roff (this)",
|
|
ind + "#",
|
|
ind + "# hdtbl renders its example tables to PostScript, and one of them shows",
|
|
ind + "# the GNU logo. HDTBLPROCESSEDEXAMPLEFILES lists all twelve; the whole",
|
|
ind + "# list goes, because there is no reason to render eleven examples of a",
|
|
ind + "# table macro package into a documentation set nothing here reads.",
|
|
ind + 'sed -i "/^HDTBLPROCESSEDEXAMPLEFILES = /,/^$/ s|^.*$||" Makefile',
|
|
ind + 'grep -q "^HDTBLPROCESSEDEXAMPLEFILES" Makefile && { echo "groff: hdtbl example list not emptied" >&2; exit 1; }',
|
|
ind + "# And say it out loud: if a THIRD consumer appears, this is the pattern",
|
|
ind + "# to look for, not a new kind of problem.",
|
|
ind + 'if grep -rl "gnu\\.eps" --include="*.roff" --include="*.ms" . 2>/dev/null | grep -qv "^\\./doc/webpage.ms$\\|mixed_pickles"; then',
|
|
ind + ' echo "groff: a third file includes gnu.eps; see patches/pkgbuild/groff.sh" >&2',
|
|
ind + ' exit 1',
|
|
ind + 'fi',
|
|
]
|
|
io.open("PKGBUILD", "w", encoding="utf-8").write("\n".join(lines))
|
|
ZZPY
|
|
grep -q "DOC_GNU_EPS" PKGBUILD || { echo "groff: the figure was not dropped" >&2; exit 1; }
|
|
# The grep inside build() is the real check: it runs against the generated
|
|
# Makefile and fails the build if the variable was not what this hook expects.
|
|
grep -q 'grep -q "\^DOC_GNU_EPS =\$" Makefile' PKGBUILD || {
|
|
echo "groff: the in-build verification is missing" >&2; exit 1; }
|
|
echo "groff: GNU logo figure dropped (no netpbm)"
|