Mathieu Benoit
8d9e8a4dce
groff was the third round on the same package: DOC_GNU_EPS, then PROCESSEDEXAMPLEFILES_PS, then HDTBL -- and mom's examples were waiting behind those. groff renders its own manuals and every contrib package's examples with the groff being built, each list a separate variable. Finding them one failure at a time cost three passes; all seven are emptied together now. systemd is the fourth package to stop on missing DocBook DATA rather than a missing tool -- xsltproc exists, our libxslt supplies it: compilation error: file ../systemd/man/custom-man.xsl line 12 element import It has the largest man page set here, which is the strongest argument in this port for shipping docbook-xsl eventually. git's libsecret helper needed THREE places, one spanning two lines. The first version asserted "expected one _make, got 2" and stopped -- the guard working. Replacing the install's first line alone would have left its continuation as a command of its own, which is the binutils trap again. --- FR --- groff en était au troisième tour sur le même paquet : DOC_GNU_EPS, puis PROCESSEDEXAMPLEFILES_PS, puis HDTBL — et les exemples de mom attendaient derrière. groff rend ses propres manuels et les exemples de chaque contrib avec le groff en cours de construction, chaque liste étant une variable distincte. Les trouver un échec à la fois a coûté trois passes ; les sept sont vidées ensemble. systemd est le quatrième paquet à s'arrêter sur des DONNÉES DocBook absentes et non sur un outil manquant — xsltproc existe, notre libxslt le fournit : compilation error: file ../systemd/man/custom-man.xsl line 12 element import Il porte le plus grand ensemble de pages de manuel du portage : c'est le meilleur argument pour livrer docbook-xsl à terme. L'aide libsecret de git demandait TROIS endroits, dont un sur deux lignes. La première version a affirmé « expected one _make, got 2 » et s'est arrêtée — le garde faisant son travail. Remplacer la première ligne de l'installation aurait laissé sa continuation comme commande à part, soit le piège de binutils à nouveau. Assisted-by: Claude Opus 5
94 lines
5.2 KiB
Bash
Executable file
94 lines
5.2 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
# groff: one decorative figure, and no netpbm to draw it.
|
|
#
|
|
# program 'xpmtoppm' is missing; can't generate doc/gnu.eps
|
|
# make[2]: *** [Makefile:19801: doc/gnu.eps] Error 1
|
|
#
|
|
# xpmtoppm belongs to netpbm. What it produces is the GNU logo, as EPS, for
|
|
# groff's own manual -- and getting it would mean packaging netpbm and the image
|
|
# libraries under it (libjpeg-turbo, libpng, libtiff, jbigkit), none of which
|
|
# anything else in this bootstrap wants.
|
|
#
|
|
# NO CONFIGURE SWITCH EXISTS: groff's configure has neither --without-doc nor
|
|
# --disable-doc, so there was nothing to turn off. Adding an invented flag would
|
|
# have been worse than useless -- autoconf merely warns about options it does not
|
|
# know, the build would have failed identically, and the hook's own check would
|
|
# have passed.
|
|
#
|
|
# The Makefile is generated, so it is edited after configure and before make. The
|
|
# variable is emptied rather than the rule patched, because the INSTALL side is
|
|
# already tolerant:
|
|
#
|
|
# if test -f "$$d/gnu.eps"; then ... fi
|
|
#
|
|
# so with nothing built, nothing is installed and nothing complains. One line,
|
|
# and the only one whose absence the rest of the Makefile already handles.
|
|
set -euo pipefail
|
|
python3 - <<'ZZPY'
|
|
import io, re
|
|
lines = io.open("PKGBUILD", encoding="utf-8").read().split("\n")
|
|
mk = [i for i, l in enumerate(lines) if re.match(r"^[ \t]*make[ \t]*$", l)]
|
|
assert len(mk) >= 1, "groff: no bare `make` line found in build()"
|
|
i = mk[0]
|
|
ind = re.match(r"^[ \t]*", lines[i]).group(0)
|
|
lines[i:i] = [
|
|
ind + "# doc/gnu.eps needs xpmtoppm from netpbm, which this port does not",
|
|
ind + "# package. The install side already skips the file when it is absent.",
|
|
ind + 'sed -i "s|^DOC_GNU_EPS = doc/gnu.eps$|DOC_GNU_EPS =|" Makefile',
|
|
ind + 'grep -q "^DOC_GNU_EPS =$" Makefile',
|
|
ind + "# And its CONSUMER. Emptying DOC_GNU_EPS removed the rule that",
|
|
ind + "# builds the figure and not the document that includes it:",
|
|
ind + "#",
|
|
ind + "# doc/webpage.ms:45: error: cannot open 'gnu.eps'",
|
|
ind + "# doc/webpage.ms:45: fatal error: PSPIC failed to include 'gnu.eps'",
|
|
ind + "#",
|
|
ind + "# PROCESSEDEXAMPLEFILES_PS lists webpage.ps and grnexmpl.ps. The",
|
|
ind + "# HTML variant right above it is ALREADY empty, with its real value",
|
|
ind + "# left as a comment -- groff's own configure empties that one when",
|
|
ind + "# the tools are missing. This does the same for PS, which is the",
|
|
ind + "# decision groff would have made had it checked.",
|
|
ind + 'sed -i "/^PROCESSEDEXAMPLEFILES_PS = /,/^$/ s|^.*$||" Makefile',
|
|
ind + 'grep -q "^PROCESSEDEXAMPLEFILES_PS" Makefile && { echo "groff: PS example list not emptied" >&2; exit 1; }',
|
|
ind + "# THE SECOND consumer. Two files include the logo, and only two --",
|
|
ind + "# counted rather than guessed:",
|
|
ind + "#",
|
|
ind + "# doc/webpage.ms (above)",
|
|
ind + "# contrib/hdtbl/examples/mixed_pickles.roff (this)",
|
|
ind + "#",
|
|
ind + "# hdtbl renders its example tables to PostScript, and one of them shows",
|
|
ind + "# the GNU logo. HDTBLPROCESSEDEXAMPLEFILES lists all twelve; the whole",
|
|
ind + "# list goes, because there is no reason to render eleven examples of a",
|
|
ind + "# table macro package into a documentation set nothing here reads.",
|
|
ind + "# ALL of them, not one per failure. This is the third round on the",
|
|
ind + "# same package: DOC_GNU_EPS, then PROCESSEDEXAMPLEFILES_PS, then",
|
|
ind + "# HDTBL, and mom's examples were waiting behind those --",
|
|
ind + "#",
|
|
ind + "# pdfmom: fatal error: test-groff exited with status 4",
|
|
ind + "# contrib/mom/examples/typesetting.pdf",
|
|
ind + "#",
|
|
ind + "# groff renders its own manuals and every contrib package's examples",
|
|
ind + "# to PostScript and PDF using the groff being built. Each list is a",
|
|
ind + "# separate variable, and finding them one failure at a time is how",
|
|
ind + "# three passes went by. They are emptied together.",
|
|
ind + 'for _v in HDTBLPROCESSEDEXAMPLEFILES MOMPROCESSEDEXAMPLEFILES \\',
|
|
ind + ' PROCESSEDDOCFILES_PDF PROCESSEDDOCFILES_PS \\',
|
|
ind + ' PROCESSEDDOCFILES_TXT PROCESSEDDOCFILES \\',
|
|
ind + ' GENERATEDDOCFILES; do',
|
|
ind + ' sed -i "/^$_v = /,/^$/ s|^.*$||" Makefile',
|
|
ind + ' grep -q "^$_v" Makefile && { echo "groff: $_v not emptied" >&2; exit 1; }',
|
|
ind + 'done',
|
|
ind + "# And say it out loud: if a THIRD consumer appears, this is the pattern",
|
|
ind + "# to look for, not a new kind of problem.",
|
|
ind + 'if grep -rl "gnu\\.eps" --include="*.roff" --include="*.ms" . 2>/dev/null | grep -qv "^\\./doc/webpage.ms$\\|mixed_pickles"; then',
|
|
ind + ' echo "groff: a third file includes gnu.eps; see patches/pkgbuild/groff.sh" >&2',
|
|
ind + ' exit 1',
|
|
ind + 'fi',
|
|
]
|
|
io.open("PKGBUILD", "w", encoding="utf-8").write("\n".join(lines))
|
|
ZZPY
|
|
grep -q "DOC_GNU_EPS" PKGBUILD || { echo "groff: the figure was not dropped" >&2; exit 1; }
|
|
# The grep inside build() is the real check: it runs against the generated
|
|
# Makefile and fails the build if the variable was not what this hook expects.
|
|
grep -q 'grep -q "\^DOC_GNU_EPS =\$" Makefile' PKGBUILD || {
|
|
echo "groff: the in-build verification is missing" >&2; exit 1; }
|
|
echo "groff: GNU logo figure dropped (no netpbm)"
|