Mathieu Benoit
7fa489b5bb
p11-kit is the twelfth instance of removing a documentation build and leaving its install: -D gtk_doc=false stopped the docs being made, and package() still ran `_pick doc "$pkgdir"/usr/share/gtk-doc`. _pick is Arch's helper for moving a path into a sub-package and it is as fatal on a missing path as a bare mv. tpm2-tss had two obstacles and the first hid the second. Before autoconf-archive existed it died on configure.ac:139: error: undefined or overquoted macro: AC_MSG_WARN naming a macro that exists -- an AX_* macro was missing, m4 quoting came apart, and autoconf blamed the next thing it recognised. With the archive installed, configure gets far enough to ask for cmocka, a C unit-test framework wanted only for tests this pass does not run. --- FR --- p11-kit est la douzième occurrence du retrait d'une construction de documentation sans son installation : -D gtk_doc=false a arrêté la production, et package() exécutait toujours `_pick doc "$pkgdir"/usr/share/gtk-doc`. _pick est l'aide d'Arch pour déplacer un chemin vers un sous-paquet, et elle est aussi fatale qu'un mv nu sur un chemin absent. tpm2-tss avait deux obstacles, et le premier masquait le second. Avant l'existence d'autoconf-archive il mourait sur configure.ac:139: error: undefined or overquoted macro: AC_MSG_WARN nommant une macro qui existe — une macro AX_* manquait, la citation m4 s'est défaite, et autoconf a accusé la chose suivante qu'il reconnaissait. L'archive installée, configure va assez loin pour réclamer cmocka, cadre de tests unitaires en C voulu seulement pour des tests que cette passe ne lance pas. Assisted-by: Claude Opus 5
80 lines
3.8 KiB
Bash
Executable file
80 lines
3.8 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
# p11-kit: no gtk-doc manual.
|
|
#
|
|
# meson.build:65:18: ERROR: Dependency "glib-2.0" not found (tried pkgconfig)
|
|
#
|
|
# THIS ONE WAS NEARLY A SUB-PROJECT. glib-2.0 is not in this port, and adding it
|
|
# is not one package: Arch's glib2 wants gobject-introspection (which itself
|
|
# needs glib2 -- a cycle to bootstrap), libsysprof-capture, dconf and gi-docgen.
|
|
# Several packages and a circular dependency, for one entry in one build.
|
|
#
|
|
# Reading where the requirement actually comes from changed the answer entirely.
|
|
# The file is doc/manual/meson.build, and the line is
|
|
#
|
|
# glib_prefix = dependency('glib-2.0').get_variable(pkgconfig : 'prefix')
|
|
#
|
|
# glib is consulted to find where gtk-doc keeps its cross-reference files. It is
|
|
# not linked, not called, and nothing in p11-kit's code touches it. -D gtk_doc
|
|
# is already in the PKGBUILD's option list, set to true; turning it false drops
|
|
# the whole doc/manual subdirectory and the dependency with it.
|
|
#
|
|
# The lesson is the one this port keeps relearning: the error names glib, and
|
|
# glib is not the subject. Six lines of context said so.
|
|
set -euo pipefail
|
|
python3 - <<'ZZPY'
|
|
import io, re
|
|
lines = io.open("PKGBUILD", encoding="utf-8").read().split("\n")
|
|
hit = [i for i, l in enumerate(lines) if re.match(r"^[ \t]*-D gtk_doc=true[ \t]*$", l)]
|
|
assert len(hit) == 1, "p11-kit: expected one -D gtk_doc=true, got %d" % len(hit)
|
|
lines[hit[0]] = lines[hit[0]].replace("gtk_doc=true", "gtk_doc=false")
|
|
io.open("PKGBUILD", "w", encoding="utf-8").write("\n".join(lines))
|
|
ZZPY
|
|
grep -q -- "-D gtk_doc=false" PKGBUILD || { echo "p11-kit: gtk_doc not disabled" >&2; exit 1; }
|
|
echo "p11-kit: gtk-doc manual disabled (glib was only locating its xrefs)"
|
|
|
|
# --- and no man pages either --------------------------------------------------
|
|
#
|
|
# With gtk_doc off, the next line was
|
|
#
|
|
# meson.build:94:4: ERROR: Problem encountered: Docbook stylesheet for man
|
|
# pages not found
|
|
#
|
|
# The stylesheets, not xsltproc -- which our libxslt supplies. Third package to
|
|
# stop on exactly this: pam validates DocBook sources it cannot fetch, shadow
|
|
# renders man pages from them. Shipping docbook-xsl would be a package that only
|
|
# documentation needs; -D man is already in the option list.
|
|
python3 - <<'ZZPY'
|
|
import io, re
|
|
lines = io.open("PKGBUILD", encoding="utf-8").read().split("\n")
|
|
hit = [i for i, l in enumerate(lines) if re.match(r"^[ \t]*-D man=true[ \t]*$", l)]
|
|
assert len(hit) == 1, "p11-kit: expected one -D man=true, got %d" % len(hit)
|
|
lines[hit[0]] = lines[hit[0]].replace("man=true", "man=false")
|
|
io.open("PKGBUILD", "w", encoding="utf-8").write("\n".join(lines))
|
|
ZZPY
|
|
grep -q -- "-D man=false" PKGBUILD || { echo "p11-kit: man not disabled" >&2; exit 1; }
|
|
echo "p11-kit: man pages disabled (DocBook stylesheets absent, not xsltproc)"
|
|
|
|
# --- and the gtk-doc split ----------------------------------------------------
|
|
#
|
|
# mv: cannot stat '<pkgdir>/usr/share/gtk-doc': No such file or directory
|
|
#
|
|
# TWELFTH time. -D gtk_doc=false above stopped the documentation being built and
|
|
# left package() splitting it out:
|
|
#
|
|
# _pick doc "$pkgdir"/usr/share/gtk-doc
|
|
#
|
|
# _pick is Arch's helper for moving a path into a sub-package, and it is as fatal
|
|
# on a missing path as a bare mv.
|
|
python3 - <<'ZZPY'
|
|
import io, re
|
|
lines = io.open("PKGBUILD", encoding="utf-8").read().split("\n")
|
|
hit = [i for i, l in enumerate(lines) if "gtk-doc" in l and "_pick" in l]
|
|
assert len(hit) == 1, "p11-kit: expected one gtk-doc _pick, got %d" % len(hit)
|
|
i = hit[0]
|
|
ind = re.match(r"^[ \t]*", lines[i]).group(0)
|
|
lines[i] = ind + ": # gtk_doc is false above, so usr/share/gtk-doc is never created."
|
|
io.open("PKGBUILD", "w", encoding="utf-8").write("\n".join(lines))
|
|
ZZPY
|
|
grep -qE "_pick doc .*gtk-doc" PKGBUILD && {
|
|
echo "p11-kit: the gtk-doc pick survived" >&2; exit 1; }
|
|
echo "p11-kit: gtk-doc split removed (nothing builds it now)"
|