Mathieu Benoit
36d726f0a1
crypto/ec/ec_local.h:520:2: error:
"Can not enable ec_nistp_64_gcc_128 on big-endian systems"
Arch enables this elliptic-curve optimisation, which uses a 128-bit
integer representation that assumes little-endian byte order. s390x is
BIG-endian.
This is the first time in the whole port that endianness -- rather than
word size, instruction set or packaging layout -- decides anything. Ten
packages so far diverged on 32-bit multilib, missing front ends or path
conventions; this one diverges on how bytes are ordered in a word.
OpenSSL refuses at compile time rather than producing wrong results,
which is the right call and makes this one honest to diagnose. Dropping
the flag costs some NIST curve performance and nothing else: the curves
still work through the portable implementation.
--- FR ---
crypto/ec/ec_local.h:520:2: error:
"Can not enable ec_nistp_64_gcc_128 on big-endian systems"
Arch active cette optimisation de courbes elliptiques, qui repose sur
une representation entiere 128 bits supposant l ordre petit-boutiste.
s390x est GROS-boutiste.
C est la premiere fois dans tout le portage que l endianness -- et non
la taille de mot, le jeu d instructions ou la convention de chemins --
tranche quoi que ce soit. Dix paquets ont diverge jusqu ici sur le
multilib 32 bits, des frontaux absents ou des dispositions de
repertoires ; celui-ci diverge sur l ordre des octets dans un mot.
OpenSSL refuse a la compilation plutot que de produire des resultats
faux, ce qui est le bon choix et rend ce cas honnete a diagnostiquer.
Retirer l option coute un peu de performance sur les courbes NIST, et
rien d autre : elles fonctionnent par l implementation portable.
Assisted-by: Claude Opus 5
44 lines
1.9 KiB
Bash
Executable file
44 lines
1.9 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
# openssl: s390x needs the 64-bit Configure target.
|
|
#
|
|
# The PKGBUILD composes its target as "linux-$CARCH", which gives
|
|
# linux-s390x. That IS a valid OpenSSL target -- it is the 31-bit one. The
|
|
# 64-bit target is linux64-s390x, and building 31-bit objects on a 64-bit
|
|
# system fails without ever saying so plainly: the log ends on
|
|
#
|
|
# Configuring OpenSSL version 3.6.3 for target linux-s390x
|
|
#
|
|
# and the failure looks like it came from nowhere.
|
|
#
|
|
# The PKGBUILD already special-cases exactly this for riscv64, so the fix is
|
|
# to join that case rather than invent a mechanism.
|
|
set -euo pipefail
|
|
python3 - <<'PY'
|
|
import io
|
|
s = io.open("PKGBUILD", encoding="utf-8").read()
|
|
old = '\t"riscv64")\n'
|
|
assert old in s, "riscv64 case not found"
|
|
s = s.replace(old, '\t"s390x" | "riscv64")\n', 1)
|
|
io.open("PKGBUILD", "w", encoding="utf-8").write(s)
|
|
PY
|
|
grep -q '"s390x" | "riscv64")' PKGBUILD || { echo "openssl: case not extended" >&2; exit 1; }
|
|
echo "openssl: Configure target set to linux64-s390x (linux-s390x is 31-bit)"
|
|
|
|
# enable-ec_nistp_64_gcc_128: little-endian only.
|
|
#
|
|
# crypto/ec/ec_local.h:520:2: error:
|
|
# "Can not enable ec_nistp_64_gcc_128 on big-endian systems"
|
|
#
|
|
# Arch turns on this elliptic-curve optimisation, which uses a 128-bit
|
|
# integer representation that assumes little-endian byte order. s390x is
|
|
# BIG-endian -- the first time endianness, rather than word size or
|
|
# instruction set, decides anything in this port.
|
|
#
|
|
# OpenSSL refuses at compile time rather than producing wrong results, which
|
|
# is the right behaviour and makes this one honest to diagnose. Dropping the
|
|
# flag costs some NIST curve performance and nothing else: the curves still
|
|
# work through the portable implementation.
|
|
sed -i '/enable-ec_nistp_64_gcc_128/d' PKGBUILD
|
|
grep -q 'enable-ec_nistp_64_gcc_128' PKGBUILD && {
|
|
echo "openssl: little-endian EC optimisation still enabled" >&2; exit 1; }
|
|
echo "openssl: ec_nistp_64_gcc_128 disabled (s390x is big-endian)"
|