- Fix KeyError: 'relationship' by updating all controller methods to use 'contact_type' field
- Fix AttributeError: 'phone' by changing template references to use 'mobile' field
- Remove references to non-existent fields (email, notes) from emergency contact forms
- Fix XML syntax errors in emergency contact templates
- Grant create/write permissions to portal treatment professionals on res.partner model
- Update patient notes button URL from /my/patient/notes to /my/injury/notes
- Fix emergency contact form validation and field assignments in controllers
- Ensure all field references match actual sports.patient.contact model schema
Resolves portal 500 errors when viewing player details and managing emergency contacts.
Therapists can now successfully add/edit emergency contacts without field reference errors.
- Fix ACL test assumptions about browse() behavior
* Update tests to check field-level access instead of browse().exists()
* Correct test methodology for AccessError validation
- Implement buddy method pattern for RPC security
* Refactor all sudo()/api.model methods to use public/private pattern
* Public methods perform access checks, private methods contain privileged ops
* Prevents RPC privilege escalation vulnerabilities
- Enhanced security architecture
* Add comprehensive mail activity portal access rules
* Strengthen partner access controls
* Update controller method references to use secure public methods
- Test suite improvements
* Add extensive mail activity portal access tests
* Update player removal tests to use public method interfaces
* Improve test coverage for security scenarios
- Security best practices enforcement
* All privileged operations now encapsulated in private methods
* Clear separation between public API and internal operations
* Maintains functionality while securing RPC access
Resolves RPC security vulnerabilities and establishes proper ACL enforcement patterns.
- Removed models/injury_models.py and all its references
- Converted relational fields to character fields:
- body_location_id → body_location
- injury_type_id → injury_type
- Updated portal templates to use text inputs instead of dropdowns
- Updated controller code to process the new field formats
- Removed related access rights from security CSV
- Modified test files to accommodate the new structure
This refactoring simplifies the data model by removing unnecessary
classifications that were adding complexity without significant benefit.
The direct text fields maintain the same functionality while reducing
the database overhead and simplifying the UI.
- Refactor portal templates to eliminate intra-module template inheritance
- Integrate emergency contacts section into player injuries template
- Add full internal admin views for treatment notes with chatter support
- Fix ORM warning in test_rights by using proper ORM commands
- Update manifest to reflect new functionality (v18.0.1.9.0)
This refactoring improves template stability by removing XPath errors and
provides treatment professionals with better access to emergency contacts
and treatment notes both in portal and backend interfaces.
